Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added instructions for enabling/disabling enhancement sync job to enhancements handbook #2373

Merged
merged 3 commits into from
Apr 24, 2024
Merged

Added instructions for enabling/disabling enhancement sync job to enhancements handbook #2373

merged 3 commits into from
Apr 24, 2024

Conversation

sreeram-venkitesh
Copy link
Member

What type of PR is this:

/kind documentation

What this PR does / why we need it:

Adds instructions to the enhancements handbook about enabling and disabling the test-infra cronjob that syncs KEPs with the lead-opt-in label to the enhancements GitHub project board.

Which issue(s) this PR fixes:

None. (Didn't create an issue, this was part of a discussion in the enhancements team about the improvements we can make after the code freeze).

Special notes for your reviewer:

None.

@k8s-ci-robot k8s-ci-robot added kind/documentation Categorizes issue or PR as related to documentation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority labels Nov 22, 2023
@k8s-ci-robot k8s-ci-robot added area/release-team Issues or PRs related to the release-team subproject sig/release Categorizes an issue or PR as relevant to SIG Release. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 22, 2023
@sreeram-venkitesh
Copy link
Member Author

Part of #2375

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 26, 2024
@sreeram-venkitesh
Copy link
Member Author

/remove-lifecycle stale

@salehsedghpour Can you take a look at this? We had discussed these at the end of the 1.29 cycle.

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 26, 2024
@salehsedghpour
Copy link
Contributor

salehsedghpour commented Feb 26, 2024 •
edited
Loading

Thanks @sreeram-venkitesh it looks good to me.

When creating the Enhancements Tracking Board for v1.30, I noticed that we may need to give k8s-infra-ci-robot the write access. Moreover, according to this thread in slack, we may need to grant prod-readiness-reviewers the write access as well. Am I write @katcosgrove?

May you please consider adding these two around line 122 @sreeram-venkitesh?

@sreeram-venkitesh
Copy link
Member Author

@npolshakova Thanks for the review, I've committed the change.

@salehsedghpour, I've added the instructions for adding the production-readiness-reviewers team and k8s-infra-ci-robot to the enhancements board in bf6dedb. Please take a look!

npolshakova
npolshakova approved these changes Apr 24, 2024
View reviewed changes
Copy link
Contributor

@npolshakova npolshakova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 24, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: npolshakova, sreeram-venkitesh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 24, 2024
@k8s-ci-robot k8s-ci-robot merged commit d32a5d4 into kubernetes:master Apr 24, 2024
2 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.31 milestone Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@npolshakova npolshakova npolshakova approved these changes

@Atharva-Shinde Atharva-Shinde Awaiting requested review from Atharva-Shinde

Assignees

@npolshakova npolshakova

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-team Issues or PRs related to the release-team subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority sig/release Categorizes an issue or PR as relevant to SIG Release. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.31
Development

Successfully merging this pull request may close these issues.
5 participants
@sreeram-venkitesh @k8s-triage-robot @salehsedghpour @k8s-ci-robot @npolshakova